Charcoal or gas? How about both?
I rarely use the gas. Mostly during the wintertime because I can get a more consistent heat while grilling. I also have a Brinkman gas smoker. It's not insulated so smoking during the winter is a PITA. Year round, I found the best results is to smoke for an hour and finish off in the oven. I like a mix of hickory and apple chips for pork. I've attempted to try and smoke fish a # of times and never once been successful.